Skip to content

LWG-3848: slide_view missing base accessor#3410

Merged
StephanTLavavej merged 3 commits intomicrosoft:mainfrom
JMazurkiewicz:lwg3848
Feb 14, 2023
Merged

LWG-3848: slide_view missing base accessor#3410
StephanTLavavej merged 3 commits intomicrosoft:mainfrom
JMazurkiewicz:lwg3848

Conversation

@JMazurkiewicz
Copy link
Contributor

@JMazurkiewicz JMazurkiewicz commented Feb 12, 2023 •
edited by StephanTLavavej
Loading

This PR adds base accessor to ranges::slide_view implemented in #2670.

Fixes #3409.

@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner February 12, 2023 00:01
@StephanTLavavej StephanTLavavej added LWG Library Working Group issue ranges C++20/23 ranges labels Feb 12, 2023
@StephanTLavavej StephanTLavavej mentioned this pull request Feb 12, 2023
Closed
61 tasks
StephanTLavavej
StephanTLavavej reviewed Feb 12, 2023
View reviewed changes
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Feb 12, 2023

Thanks! I pushed a tiny commit to remove an unnecessary check (copy-pasted?).

@JMazurkiewicz
Copy link
Contributor Author

JMazurkiewicz commented Feb 12, 2023 •
edited
Loading

Thanks! I pushed a tiny commit to remove an unnecessary check (copy-pasted?).

Yes, it was copy-pasted from P2442R1_views_chunk/test.cpp - and it looks like this check is also uneccessary there.

SuperWig
SuperWig reviewed Feb 12, 2023
View reviewed changes
@JMazurkiewicz
Copy link
Contributor Author

JMazurkiewicz commented Feb 12, 2023

FYI I've pushed two extra changes:

  • // strengthend comment for base and size members tests,
  • Correct exception check for slide_view::size.

@StephanTLavavej StephanTLavavej self-assigned this Feb 13, 2023
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Feb 13, 2023

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit aee02b5 into microsoft:main Feb 14, 2023
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Feb 14, 2023

Thanks for helping the STL slide towards increased conformance! 🎚️ 📈 😻

@JMazurkiewicz JMazurkiewicz deleted the lwg3848 branch February 14, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+3 more reviewers

@SuperWig SuperWig SuperWig left review comments

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej StephanTLavavej

Labels

LWG Library Working Group issue ranges C++20/23 ranges

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

LWG-3848 adjacent_view, adjacent_transform_view, and slide_view missing base accessor

5 participants

@JMazurkiewicz @StephanTLavavej @CaseyCarter @SuperWig @strega-nil-ms